timers: remove domain enter and exit#17880
Closed
apapirovski wants to merge 1 commit into
Closed
Conversation
With domains implemented over AsyncHooks, it's no longer necessary to explicitly enter and exit the domain.
nodejs-github-bot
added
the
timers
addaleax
approved these changes
Dec 27, 2017
addaleax
left a comment
addaleax
left a comment
Member
There was a problem hiding this comment.
This is a very good change. 👍
cjihrig
approved these changes
Dec 27, 2017
Contributor
Author
jasnell
approved these changes
Dec 27, 2017
7 tasks
AndreasMadsen
approved these changes
Dec 28, 2017
AndreasMadsen
left a comment
AndreasMadsen
left a comment
Member
There was a problem hiding this comment.
LGTM, I've updated #17143
apapirovski
added
the
author ready
Contributor
Author
|
Landed in 2c94424 |
apapirovski
added a commit
that referenced
this pull request
Dec 31, 2017
With domains implemented over AsyncHooks, it's no longer necessary to explicitly enter and exit the domain. PR-URL: #17880 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
With domains implemented over AsyncHooks, it's no longer necessary to explicitly enter and exit the domain. PR-URL: #17880 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
With domains implemented over AsyncHooks, it's no longer necessary to explicitly enter and exit the domain. PR-URL: #17880 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
With domains implemented over AsyncHooks, it's no longer necessary to explicitly enter and exit the domain. PR-URL: #17880 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Merged
TimothyGu
removed
the
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With domains implemented over
AsyncHook, it's no longer necessary to explicitly enter and exit the domain.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
timers